Changeset 963:35b2e35e9e07

Timestamp:

05/14/19 18:02:30 (6 years ago)

Author:

István Váradi <ivaradi@…>

Branch:

python3

Phase:

public

Message:

METAR downloading and processing is more robust

File:

• src/mlx/web.py (modified) (1 diff)

src/mlx/web.py

@@ -1052 +1052 @@
                                   ("hoursBeforeNow", "24"),
                                   ("mostRecentForEachStation", "constraint")])
-        url += data
-        f = urllib.request.urlopen(url, timeout = 10.0, cafile=certifi.where())
+        result = Result()
+        result.metars = {}
         try:
-            result = Result()
-            result.metars = {}
-            for line in f.readlines():
-                line = str(line, "iso-8859-1")
-                if len(line)>5 and line[4]==' ':
-                    icao = line[0:4]
-                    if icao in self._airports:
-                        result.metars[icao] = line.strip().split(",")[0]
-        finally:
-            f.close()
+            url += data
+            f = urllib.request.urlopen(url, timeout = 10.0, cafile = certifi.where())
+            try:
+                for line in f.readlines():
+                    line = str(line, "iso-8859-1")
+                    if len(line)>5 and line[4]==' ':
+                        icao = line[0:4]
+                        if icao in self._airports:
+                            result.metars[icao] = line.strip().split(",")[0]
+            finally:
+                f.close()
+        except Exception as e:
+            traceback.print_exc()
+            print("mlx.web.GetMETARs.run: failed to get METARs for %s: %s" % \
+                  (self._airports, str(e)))
 
         return result