Changeset 124:6633722f7f86 for src/mlx/gui

Timestamp:

04/29/12 07:37:22 (13 years ago)

Author:

István Váradi <ivaradi@…>

Branch:

default

Phase:

public

Message:

The buttons are now explicitly defined for message dialogs to avoid language problems

Location:

src/mlx/gui

Files:

• common.py (modified) (2 diffs)
• flight.py (modified) (5 diffs)
• gui.py (modified) (2 diffs)
• prefs.py (modified) (3 diffs)
• update.py (modified) (1 diff)

src/mlx/gui/common.py

@@ -24 +24 @@
     MESSAGETYPE_QUESTION = gtk.MESSAGE_QUESTION
     MESSAGETYPE_INFO = gtk.MESSAGE_INFO
-    BUTTONSTYPE_OK = gtk.BUTTONS_OK
-    BUTTONSTYPE_YES_NO = gtk.BUTTONS_YES_NO
+    RESPONSETYPE_OK = gtk.RESPONSE_OK
     RESPONSETYPE_YES = gtk.RESPONSE_YES
+    RESPONSETYPE_NO = gtk.RESPONSE_NO
     RESPONSETYPE_ACCEPT = gtk.RESPONSE_ACCEPT
     RESPONSETYPE_REJECT = gtk.RESPONSE_REJECT
@@ -49 +49 @@
     MESSAGETYPE_QUESTION = gtk.MessageType.QUESTION
     MESSAGETYPE_INFO = gtk.MessageType.INFO
-    BUTTONSTYPE_OK = gtk.ButtonsType.OK
-    BUTTONSTYPE_YES_NO = gtk.ButtonsType.YES_NO
+    RESPONSETYPE_OK = gtk.ResponseType.OK
     RESPONSETYPE_YES = gtk.ResponseType.YES
+    RESPONSETYPE_NO = gtk.ResponseType.NO
     RESPONSETYPE_ACCEPT = gtk.ResponseType.ACCEPT
     RESPONSETYPE_REJECT = gtk.ResponseType.REJECT

src/mlx/gui/flight.py

@@ -306 +306 @@
                 dialog = gtk.MessageDialog(parent = self._wizard.gui.mainWindow,
                                            type = MESSAGETYPE_ERROR,
-                                           buttons = BUTTONSTYPE_OK,
                                            message_format = xstr("login_invalid"))
+                dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
                 dialog.set_title(WINDOW_TITLE_BASE)
                 dialog.format_secondary_markup(xstr("login_invalid_sec"))
@@ -315 +315 @@
             dialog = gtk.MessageDialog(parent = self._wizard.gui.mainWindow,
                                        type = MESSAGETYPE_ERROR,
-                                       buttons = BUTTONSTYPE_OK,
                                        message_format = xstr("login_failconn"))
+            dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
             dialog.set_title(WINDOW_TITLE_BASE)
             dialog.format_secondary_markup(xstr("login_failconn_sec"))
@@ -523 +523 @@
             dialog = gtk.MessageDialog(parent = self._wizard.gui.mainWindow,
                                        type = MESSAGETYPE_ERROR,
-                                       buttons = BUTTONSTYPE_OK,
                                        message_format = xstr("gatesel_conflict"))
+            dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
             dialog.set_title(WINDOW_TITLE_BASE)
             dialog.format_secondary_markup(xstr("gatesel_conflict_sec"))
@@ -1880 +1880 @@
         
         dialog = gtk.MessageDialog(parent = self._wizard.gui.mainWindow,
-                                   type = type, buttons = BUTTONSTYPE_OK,
-                                   message_format = messageFormat)
+                                   type = type, message_format = messageFormat)
+        dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
         dialog.set_title(WINDOW_TITLE_BASE)
         if secondaryMarkup is not None:
@@ -2140 +2140 @@
             dialog = gtk.MessageDialog(parent = self.gui.mainWindow,
                                        type = MESSAGETYPE_ERROR,
-                                       buttons = BUTTONSTYPE_OK,
                                        message_format =
                                        xstr("fleet_update_failed"))
+            dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
             dialog.set_title(WINDOW_TITLE_BASE)
             dialog.run()

src/mlx/gui/gui.py

@@ -581 +581 @@
             dialog = gtk.MessageDialog(parent = self.mainWindow,
                                        type = MESSAGETYPE_ERROR,
-                                       buttons = BUTTONSTYPE_OK,
                                        message_format = xstr("fleet_failed"))
+            dialog.add_button(xstr("button_ok"), RESPONSETYPE_ACCEPT)
             dialog.set_title(WINDOW_TITLE_BASE)
             dialog.run()
@@ -756 +756 @@
             dialog = gtk.MessageDialog(parent = self._mainWindow,
                                        type = MESSAGETYPE_QUESTION,
-                                       buttons = BUTTONSTYPE_YES_NO,
                                        message_format = xstr("quit_question"))
+
+            dialog.add_button(xstr("button_no"), RESPONSETYPE_NO)
+            dialog.add_button(xstr("button_yes"), RESPONSETYPE_YES)
 
             dialog.set_title(WINDOW_TITLE_BASE)

src/mlx/gui/prefs.py

@@ -19 +19 @@
                                           xstr("prefs_title"),
                                           gui.mainWindow,
-                                          DIALOG_MODAL,
-                                          (gtk.STOCK_CANCEL,
-                                           RESPONSETYPE_REJECT,
-                                           gtk.STOCK_OK,
-                                           RESPONSETYPE_ACCEPT))
+                                          DIALOG_MODAL)
+
+        self.add_button(xstr("button_cancel"), RESPONSETYPE_REJECT)
+        self.add_button(xstr("button_ok"), RESPONSETYPE_ACCEPT)
+        
         self._gui = gui
 
@@ -139 +139 @@
             dialog = gtk.MessageDialog(parent = self,
                                        type = MESSAGETYPE_INFO,
-                                       buttons = BUTTONSTYPE_OK,
                                        message_format = xstr("prefs_restart"))
+            dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
             dialog.set_title(self.get_title())
             dialog.format_secondary_markup(xstr("prefs_language_restart_sec"))
@@ -199 +199 @@
             dialog = gtk.MessageDialog(parent = self,
                                        type = MESSAGETYPE_INFO,
-                                       buttons = BUTTONSTYPE_OK,
                                        message_format = xstr("prefs_update_auto_warning"))
+            dialog.add_button(xstr("button_ok"), RESPONSETYPE_OK)
             dialog.set_title(self.get_title())
             dialog.run()

src/mlx/gui/update.py

@@ -75 +75 @@
             gtk.Dialog(WINDOW_TITLE_BASE + " " + xstr("update_title"),
                        parentWindow,
-                       gtk.DialogFlags.MODAL if pygobject else gtk.DIALOG_MODAL,
-                       (gtk.STOCK_CANCEL, 0,
-                        gtk.STOCK_OK, 1))
-
+                       gtk.DialogFlags.MODAL if pygobject else gtk.DIALOG_MODAL)
+        sudoDialog.add_button(xstr("button_cancel"), 0)
+        sudoDialog.add_button(xstr("button_ok"), 1)
+                       
         infoLabelAlignment = gtk.Alignment(xalign = 0.5, xscale = 0.1)
         infoLabelAlignment.set_padding(padding_top = 4, padding_bottom = 10,