Decouple the fuel tank representation
|Reported by:||István Váradi||Owned by:||István Váradi|
There are the interfaces where the fuel data appears:
- On the state interface, when reading the fuel from the simulator
- On the getFuel() function of the simulator which is used to read the fuel data.
- On the setFuelLevel() function.
The last two interfaces use the fuel tank constants to identify the tanks. However, the tanks in the simulator may be different from what is the real situation in the aircraft. So we have two choices:
- Either the interfaces provide a picture where the tanks are as in the real life, and thus convert between that and the data in the simulator. In this case the last two interfaces should be specific to the aircraft model used. This is probably the easier approach
- Or the interface provides the same fuel tanks as in the simulator . This makes the life of the user more difficult and a function should be provided which returns the actual fuel tanks. Perhaps getFuel() could be that. We could also query the capacities of the tanks to determine which ones are present. But it may not be a safe way...
So, determine what to do.